Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added base64 support for key and value output fmt #164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Donis-
Copy link

@Donis- Donis- commented Jan 8, 2019

Tested only with visual studio compiler/windows.
Base64 implementation taken based on results from https://github.com/gaspardpetit/base64

@edenhill
Copy link
Owner

edenhill commented Jan 9, 2019

Thank you for your contribution!

The base64 implementation is dual licensed, some old Apache license (less of a problem), and an Apple license that is troublesome.

See if you can find a 2 or 3-claused BSD license implementation of base64 instead.

@Donis-
Copy link
Author

Donis- commented Jan 9, 2019

I was skeptical about the Apple part. Before i integrate, is this one acceptable:
http://web.mit.edu/freebsd/head/contrib/wpa/src/utils/base64.c

License under :
http://web.mit.edu/freebsd/head/contrib/wpa/
3 claused?

@jjlin
Copy link

jjlin commented Aug 14, 2019

I was skeptical about the Apple part. Before i integrate, is this one acceptable:
http://web.mit.edu/freebsd/head/contrib/wpa/src/utils/base64.c

License under :
http://web.mit.edu/freebsd/head/contrib/wpa/
3 claused?

@Donis- Any near-term plans to continue with integrating the Jouni Malinen base64 implementation? If not, do you mind if I take it up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants