Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not update endpoints in cronjobs. #1071

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Do not update endpoints in cronjobs. #1071

merged 2 commits into from
Nov 25, 2024

Conversation

tgloeggl
Copy link
Member

fixes #1070

The solution in the described issue is facilitated

@tgloeggl tgloeggl added type:bug v:3 Everything related to the Stud.IP Opencast Plugin Version 3.x labels Nov 14, 2024
@tgloeggl tgloeggl added this to the Opencast 3.18 milestone Nov 14, 2024
Copy link
Collaborator

@dennis531 dennis531 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but have you considered deleting the endpoints in

Endpoints::deleteBySql('config_id = ?', [$this->id]);
after the rest components have been successfully loaded. This might solve the mentioned problem occurring when the service is unreachable.

@tgloeggl
Copy link
Member Author

Looks good, but have you considered deleting the endpoints in

Endpoints::deleteBySql('config_id = ?', [$this->id]);

after the rest components have been successfully loaded. This might solve the mentioned problem occurring when the service is unreachable.

Auch ne Variante. Hat den Vorteil, dass die Endpunkte trotzdem aktualisiert werden, sofern OC erreichbar ist.

@tgloeggl tgloeggl merged commit b2b4bec into master Nov 25, 2024
3 checks passed
@tgloeggl tgloeggl deleted the issue-1070 branch November 25, 2024 10:16
tgloeggl added a commit that referenced this pull request Nov 25, 2024
* do not update endpoints in cronjobs.

* only remove endpoints of new ones are found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug v:3 Everything related to the Stud.IP Opencast Plugin Version 3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endpoint configurations disappear, cronjobs fail
2 participants