Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle incoming links #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: handle incoming links #6

wants to merge 2 commits into from

Conversation

AmanRajSinghMourya
Copy link

Updated Intent.ACTION_VIEW to handle incoming links.

Changes

  • If data (the incoming link) is not null, the URI is extracted and stored in the result map with the key uri.

vishnukvmd
vishnukvmd reviewed Nov 8, 2024
View reviewed changes
android/src/main/kotlin/io/ente/photos/media_extension/MediaExtensionPlugin.kt Outdated
@@ -145,6 +145,9 @@ class MediaExtensionPlugin : FlutterPlugin, MethodCallHandler, ActivityAware,
resAction = IntentAction.valueOf("EDIT")
}
Intent.ACTION_VIEW -> {
if(data != null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space between if and the (. You can setup your IDE to auto-format on save :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishnukvmd vishnukvmd vishnukvmd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmanRajSinghMourya @vishnukvmd