Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: max standard rate when pressure control is UPSTREAM_CHOKE #661

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

olelod
Copy link
Contributor

@olelod olelod commented Oct 22, 2024

ECALC-1769

When the control mechanism is upstream choke, the pressure into the first compressor stage may be changed. This also changes the Am3 going in to the compressor and the Sm3 at surface conditions - hence the maximum standard rate for the compressor train should also be changed.

Have you remembered and considered?

  • I have remembered to update documentation
  • I have remembered to update manual changelog (docs/docs/changelog/next.md)
  • I have remembered to update migration guide (docs/docs/migration_guides/)
  • I have committed with BREAKING: in footer or ! in header, if breaking
  • I have added tests (if not, comment why)
  • I have used conventional commits syntax (if you squash, make sure that conventional commit is used)
  • I have included the Jira issue ID somewhere in the commit body (ECALC-XXXX)

Why is this pull request needed?

This pull request is needed because of....

What does this pull request change?

Write summary of what this pull request changes if needed.

Issues related to this change:

@olelod olelod force-pushed the ECALC-1769-fix-max-standard-rate branch from e23ac2e to f8c6e53 Compare November 5, 2024 13:10
@olelod olelod marked this pull request as ready for review November 5, 2024 13:13
@olelod olelod requested a review from a team as a code owner November 5, 2024 13:13
@olelod olelod force-pushed the ECALC-1769-fix-max-standard-rate branch from f8c6e53 to 734f821 Compare November 6, 2024 11:32
@olelod olelod force-pushed the ECALC-1769-fix-max-standard-rate branch from 734f821 to 6a8cfed Compare November 14, 2024 10:01
@olelod olelod merged commit 962ce42 into main Nov 14, 2024
8 checks passed
@olelod olelod deleted the ECALC-1769-fix-max-standard-rate branch November 14, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants