Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use spawn context for local driver #9336

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Nov 25, 2024

Issue
Resolves #my_issue

Approach
This makes uncaught exceptions from forward_model_runner propagate, but job_runner_main is already inside a blanket try-catch. When the forward_model_runner exits, it correctly sets the exitcode.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren force-pushed the use_spawn_context_for_local_driver branch 6 times, most recently from d57f5b8 to d683a6b Compare November 26, 2024 20:30
@eivindjahren eivindjahren force-pushed the use_spawn_context_for_local_driver branch from d683a6b to f291a50 Compare November 26, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant