Simplify ensemble evaluator shutdown timeout #9344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JHolba
force-pushed
the
simplify-timeout-ee
branch
from
c83f1fe
to
09a0a42
Compare
xjules
reviewed
Nov 26, 2024
| logger.error(msg) | ||
| raise RuntimeError(msg) | ||
| except asyncio.TimeoutError: | ||
| print("Timeout server done") |
There was a problem hiding this comment.
not sure, but maybe timeout=None here?
There was a problem hiding this comment.
it shouldn't cause any problem since it will at worst set _server_done multiple times, but it is more correct to set it to None there. pushed fix
JHolba
force-pushed
the
simplify-timeout-ee
branch
from
df50858
to
5d33aca
Compare
|
Now this one fails: |
jonathan-eq
reviewed
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timeout task was not always awaited. F.ex. if an exception was raised. This could cause issues with tests.
Approach
Replaced the task with the built-in timeout function of asyncio.wait
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable