👌 IMPROVE: [code load] Enable utf-8 as the standard encoding for reading code from files #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to unify across win, linux, os x
mmcky
added a commit
to QuantEcon/lecture-python.myst
that referenced
this pull request
Jun 1, 2021
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
=======================================
Coverage 87.43% 87.43%
=======================================
Files 12 12
Lines 1337 1337
=======================================
Hits 1169 1169
Misses 168 168
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mmcky
added a commit
to QuantEcon/lecture-python.myst
that referenced
this pull request
Jun 1, 2021
* enable execution checks for windows, linux, os x * test on PR first * add interpolation install from conda-forge * [temp] disable windows testing until executablebooks/MyST-NB#332 * turn of activate on push and set to schedule based testing
mmcky
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
windowsplatform doesn't by default always useutf-8when reading text from files. I think this is a sensible cross-platform default.QuantEcon/lecture-python.myst#144
There is also a related issue reported on stackoverflow