Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:setColorScheme exception when activity recreate #47955

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix:setColorScheme exception when activity recreate #47955

wants to merge 1 commit into from
+10 −7

Conversation

Maplely
Copy link

@Maplely Maplely commented Nov 26, 2024

Summary:

solve the exception on android when Appearance.setColorScheme and activity recreate()
issue:47954

Changelog:

[ANDROID] - the method setColorScheme from the ui thread

@facebook-github-bot
Copy link
Contributor

Hi @Maplely!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@react-native-bot
Copy link
Collaborator

react-native-bot commented Nov 26, 2024 •
edited
Loading

Fails
🚫

📋 Verify Changelog Format - See Changelog format
Warnings
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 5c8d195

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Nov 26, 2024
@Maplely Maplely force-pushed the features/fix_set_theme branch 2 times, most recently from f104e5c to f2b86df Compare November 26, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Maplely @facebook-github-bot @react-native-bot