This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
[extension] single source of truth for address #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YBadiss
changed the title
YBadiss
force-pushed
the
single-source-of-truth-for-address
branch
from
4266011
to
de332fe
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The address used for different actions (rate/create note, show owner's notes in the popup, ...) was not always the same.
This was caused by having both twitter.com and our extension to connect to metamask separately.
Instead we now always connect from the extension code, and we set the selected address in the storage of the extension so that code running on twitter.com can still retrieve it.
Also cleaned things up a bit, and did a refactoring of web3.js.