-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android Setup: Add information about Java and Gradle installation #772
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
I have signed the CLA |
CLAs look good, thanks! |
Co-Authored-By: asterixorobelix <[email protected]>
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Co-Authored-By: asterixorobelix <[email protected]>
@janpio It seems we need your CLA consent too |
@janpio You are now an author on this because I merged your recommendations in. Need your CLA |
|
||
The terminal command: `javac -version` should now return something similar to: `javac 1.8.0_202-ea` | ||
|
||
If this is not the case, your JAVA_HOME environment variable likely refers to a more recent version of Java. The easiest way to fix this is to uninstall all Java instances which were installed via Homebrew with `brew cask uninstall java` and then install Java 8 with `brew cask install java8` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is not the case, your JAVA_HOME environment variable likely refers to a more recent version of Java. The easiest way to fix this is to uninstall all Java instances which were installed via Homebrew with `brew cask uninstall java` and then install Java 8 with `brew cask install java8` | |
If this is not the case, your `JAVA_HOME` environment variable likely refers to a more recent version of Java. The easiest way to fix this is to uninstall all Java instances which were installed via Homebrew with `brew cask uninstall java` and then install Java 8 with `brew cask install java8` |
My consent is implied, @googlebot just can't handle it properly. As I don't work for Google, I can also not just set the label to |
Are Java and Gradle needed for all the users of fastlane for Android? If not, it might be better to actually move this further down somewhere and mention what action actually needs them. No need to make fastlane installation or usage harder than it has to be, right? |
@asterixorobelix ping 🤗 |
Friendly ping @asterixorobelix 🙈 |
As discussed in my recent issue