Feature: Adding service function RealTime Layout Service for cultures using RTL/LTR
#16514
Conversation
|
fyi @0x5bfa |
| @@ -97,6 +100,9 @@ async Task ActivateAsync() | |||
| var userSettingsService = Ioc.Default.GetRequiredService<IUserSettingsService>(); | |||
| var isLeaveAppRunning = userSettingsService.GeneralSettingsService.LeaveAppRunning; | |||
|
|
|||
| Ioc.Default.GetRequiredService<IRealTimeLayoutService>().UpdateCulture(new(AppLanguageHelper.PreferredLanguage.Code)); | |||
| MainWindow.Instance.InitializeContentLayout(); | |||
There was a problem hiding this comment.
Shouldn't this be called from MainWindow's constructor after InitializeComponent call?
There was a problem hiding this comment.
For calling, the culture must be already set by realTimeLayoutService.UpdateCulture
There was a problem hiding this comment.
I mean InitializeContentLayout shouldn't be called in MainWindow's constructor as others?
There was a problem hiding this comment.
Yes I understand, the generator works with the IoC as part of the initialization to implement the service. But the MainWindow constructor is called before the IoC is implemented.
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| namespace Files.App.Dialogs | |||
| { | |||
| public sealed partial class AddBranchDialog : ContentDialog, IDialog<AddBranchDialogViewModel> | |||
| public sealed partial class AddBranchDialog : ContentDialog, IDialog<AddBranchDialogViewModel>, IRealTimeControl | |||
There was a problem hiding this comment.
FYI, While this looks somewhat weird just for this but I'm planning to create an all-in-one service for ContentDialog & DynamicDialog to generate every dialog we use. The dialog contents will be Page class derivatives instead of the ContentDialog class.
For example:
IAppDialogService service = new();
var res = service.Show_AddBranchDialog();There was a problem hiding this comment.
IRealTimeControl can be used for all blocks that inherit from FrameworkElement, so also for Page.
| @@ -263,63 +263,68 @@ | |||
| </AnimatedIcon> | |||
| </ToggleButton> | |||
|
|
|||
| <Button | |||
| x:Name="Back" | |||
There was a problem hiding this comment.
To correct arrow direction in RTL
There was a problem hiding this comment.
What happens without this change?
There was a problem hiding this comment.
The arrows are facing each other
There was a problem hiding this comment.
Would it work to wrap these in a StackPanel (as you've done) and hardcode the FlowDirection of the StackPanel?
Yes it works because it automatically inherits FlowDirection |
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Microsoft issues
Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.
Important
This service function is only used to display the layout correctly.
Tests for RTL