Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade dependency to package_info_plus #88

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

upgrade dependency to package_info_plus #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f535855
upgrade dependency to package_info_plus
NicoloBozzatoWashOut Apr 8, 2024
12662d7
fix play core problem
nicolobozzato Jul 8, 2024
d36c122
fix app review java
nicolobozzato Jul 8, 2024
7db58e1
fix app review java
nicolobozzato Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.1.3

* Upgrading package_info_plus version to 6.0.0 which add privacy manifest for IOS

## 2.1.2

* Upgrading dependencies
Expand Down
9 changes: 6 additions & 3 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,11 @@ rootProject.allprojects {
apply plugin: 'com.android.library'

android {
compileSdkVersion 28
compileSdkVersion 34

defaultConfig {
minSdkVersion 16
minSdkVersion 24
targetSdkVersion 34
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
}
lintOptions {
Expand All @@ -35,5 +36,7 @@ android {

dependencies {
api 'androidx.legacy:legacy-support-v4:1.0.0'
implementation 'com.google.android.play:core:1.8.2'
// This dependency is downloaded from the [Google’s Maven repository](https://developer.android.com/studio/build/dependencies#google-maven).
// Make sure you also include that repository in your project's build.gradle file.
implementation 'com.google.android.play:review:2.0.1'
}
6 changes: 3 additions & 3 deletions android/src/main/java/com/appleeducate/appreview/AppReviewPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
import com.google.android.play.core.review.ReviewInfo;
import com.google.android.play.core.review.ReviewManager;
import com.google.android.play.core.review.ReviewManagerFactory;
import com.google.android.play.core.tasks.OnCompleteListener;
import com.google.android.play.core.tasks.Task;
import com.google.android.gms.tasks.OnCompleteListener;
import com.google.android.gms.tasks.Task;

import java.lang.ref.WeakReference;

Expand Down Expand Up @@ -155,4 +155,4 @@ public void onDetachedFromActivity() {
currentActivity = null;
}

}
}
4 changes: 2 additions & 2 deletions example/macos/Flutter/GeneratedPluginRegistrant.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
import FlutterMacOS
import Foundation

import package_info_plus_macos
import package_info_plus
import url_launcher_macos

func RegisterGeneratedPlugins(registry: FlutterPluginRegistry) {
FLTPackageInfoPlusPlugin.register(with: registry.registrar(forPlugin: "FLTPackageInfoPlusPlugin"))
FPPPackageInfoPlusPlugin.register(with: registry.registrar(forPlugin: "FPPPackageInfoPlusPlugin"))
UrlLauncherPlugin.register(with: registry.registrar(forPlugin: "UrlLauncherPlugin"))
}
6 changes: 3 additions & 3 deletions pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: app_review
description: Request and Write Reviews and Open Store Listing for Android and iOS in Flutter.
version: 2.1.2+1
version: 2.1.4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 2.1.4
version: 2.1.3

This should match the changelog

maintainer: Rody Davis (@rodydavis)
homepage: https://github.com/rodydavis/plugins
repository: https://github.com/fluttercommunity/app_review
Expand All @@ -10,8 +10,8 @@ environment:
flutter: ^1.10.0

dependencies:
http: ^1.1.0
package_info_plus: ^5.0.0
http: any
package_info_plus: ^6.0.0
url_launcher: ^6.1.6
flutter:
sdk: flutter
Expand Down