Add support for Java #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jssblck
requested review from
a team and
meghfossa
and removed request for
a team
meghfossa
approved these changes
Nov 29, 2023
| /// Common functionality for any type indicating a section of bytes to extract from [`Content`]. | ||
| pub trait ByteCoordinate { | ||
| /// The byte offset at which the function starts. | ||
| fn byte_start(&self) -> usize; |
There was a problem hiding this comment.
[Optional] use https://doc.rust-lang.org/std/ops/struct.Range.html instead, to get start <= x and start <= end guarantee
tests/it/language/java_11.rs
Outdated
|
|
||
| use crate::include_str_lf; | ||
|
|
||
| // #[test] |
There was a problem hiding this comment.
[Prefer] Let's kill dead comments or add one-two line explaining why we are keeping this test commented!
| import java.util.HashMap; | ||
| import java.util.logging.Logger; | ||
|
|
||
| public class TestFunctions { |
There was a problem hiding this comment.
[Optional, Minor] Let's add interface, so it's explicitly part of our test scenario.
| @@ -0,0 +1,9 @@ | |||
| //! Higher level parsers and constants on top of tree-sitter primitives. | |||
|
|
|||
There was a problem hiding this comment.
[Optional] Let's add doc url, on where we are getting these symbol tag names. I think they are coming from vendored node-types.json, according to: https://tree-sitter.github.io/tree-sitter/using-parsers#static-node-types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds support for Java snippet extraction and refactors the library a bit.
Acceptance criteria
Users can extract Java function snippets from source code.
Testing plan
Covered well by automated tests; I ran those.
Risks
None
References
https://fossa.atlassian.net/browse/ANE-1293
Checklist