Make the Volume, mode, and save channel; widgets more usable #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the Volume, mode, and save channel; widgets more usable
Make the Volume, mode, and save channel; widgets more usable
|
Landscape: |
|
Looks good, but does this work with SlideShow images on the screen? The image was already pretty constrained? What does it look like on 7" devices? |
|
I've never seen slideshow pictures, but the widget for that remained unchanged. Screen shot from real hardware, running on Android 8.1 with a 7" screen (n.b. low signal due to no antenna): |
|
Why does the scaled icon look so much worse on real hardware? Very weird. Yeah no SlideShow in the UK. Maybe this could be something which could be activated in settings? |
Scale drawables down, and not up
Scale drawables down, and not up
|
I've increased the size of the icon, and then scaled down when drawn. As to why this isn't shown in the simulator, maybe the emulated gfx chip is better than the cheap one in my hardware? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rescaled and moved Volume, mode, and save channel; widgets
Particularly in landscape devices, these buttons could be difficult to use on embedded devices