Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issues): Close dropdown on click #81286

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

scttcper
Copy link
Member

Moves onAction calls to the dropdown. For some reason mixing both to and onAction prevents it from closing on click.

CleanShot.2024-11-25.at.16.18.33.mp4

Moves onAction calls to the dropdown. For some reason mixing both to and onAction prevents it from closing.
@scttcper scttcper requested a review from a team as a code owner November 26, 2024 00:20
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../views/issueDetails/streamline/eventNavigation.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #81286   +/-   ##
=======================================
  Coverage   80.35%   80.35%           
=======================================
  Files        7221     7221           
  Lines      319588   319586    -2     
  Branches    20783    20783           
=======================================
- Hits       256806   256805    -1     
+ Misses      62387    62386    -1     
  Partials      395      395           

@scttcper scttcper merged commit c5b12fd into master Nov 26, 2024
44 of 45 checks passed
@scttcper scttcper deleted the scttcper/fix-close-dropdown branch November 26, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants