-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OMNeT++ MSG language #7023
Add OMNeT++ MSG language #7023
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very generic extension which matches way more files than your limited search which means they'll all be identified as this language.
As such, you'll need to add this extension to the generic.yml
and add a very precise heuristic that only matches files for this language.
8e7201b
to
1ab883e
Compare
I did the heuristics. Thanks. |
Based on the heuristic, I refined the popularity search: This should be a more accurate search for assessing the popularity. Thank you! |
Please merge main into your branch so CI can run. I'd normally do it but as your PR comes from an org-owned fork, permission can't be granted to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are legit failures:
1) Failure:
TestPedantic#test_heuristics_tests_are_exhaustive [test/test_pedantic.rb:62]:
Extension .msg has no test in test_heuristics.rb
We need a test for this heuristic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove samples/omnetpp-msg/Ieee80211Frame.msg
as it's too large and unnecessary as there three other files.
38df7fe
to
00fff6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely! Thanks for addressing those issues. 🙇
Thanks |
This adds the OMNeT++ MSG language.
Description
MSG (extension .msg) is a DSL for the OMNeT++ network simulator. It is used by model frameworks for OMNeT++, such as the INET framework, Simu5G, Veins, etc. We are the team that develops OMNeT++ and the INET Framework and we have created a TextMate grammar for this language.
Checklist:
#a0e0a0