-
Notifications
You must be signed in to change notification settings - Fork 60k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code examples in building-a-login-with-github-button-with-a-github-app.md #35414
base: main
Are you sure you want to change the base?
Conversation
Remove unnecessary body from http get request
Remove unnecessary body from http get request
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@arthurgubaidullin Thanks so much for opening a PR! I'll get this triaged for review ✨ |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
Remove unnecessary body from http get request
Why:
Sending body in a get request is redundant.
What's being changed (if available, include any code snippets, screenshots, or gifs):
I corrected the code examples in sections:
What's fixed:
Documentation:
send_request
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.