catches exception when Target is not a member of the organization #1304
+12
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Skipping invitations to reclaim mannequin and the target was not a member of the Org, the process will simply not return WHO the member was not part of the org providing no details on who potentially needs to be added to the org, and it will fail-fast and stopped processing any further users.
I've added a catch Exception for then "Target must be a member" so that the
HandleReclaimationResult
will log that and continue processing accordingly.Now the
HandleReclaimationResult
will output this:Enhancements to error handling:
src/Octoshift/Services/GithubApi.cs
: Added a newcatch
block to handleOctoshiftCliException
with a specific message and return a structured error result.Code improvements:
src/Octoshift/Services/GithubApi.cs
: Imported theSystem.Collections.ObjectModel
namespace to use theCollection
class.ThirdPartyNotices.txt
(if applicable)