Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catches exception when Target is not a member of the organization #1304

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amenocal
Copy link

When Skipping invitations to reclaim mannequin and the target was not a member of the Org, the process will simply not return WHO the member was not part of the org providing no details on who potentially needs to be added to the org, and it will fail-fast and stopped processing any further users.

image

I've added a catch Exception for then "Target must be a member" so that the HandleReclaimationResult will log that and continue processing accordingly.

Now the HandleReclaimationResult will output this:

[2024-11-25 22:28:54] [WARNING] Failed to reattribute content belonging to mannequin <user> (<user-id>) to <targe-user-d>: Target must be a member of the <targe-org> organization

Enhancements to error handling:

Code improvements:

  • [ ] Did you write/update appropriate tests - N\A
  • Release notes updated (if appropriate)
  • Appropriate logging output
  • Issue linked
  • Docs updated (or issue created)
  • New package licenses are added to ThirdPartyNotices.txt (if applicable)

Copy link

github-actions bot commented Nov 25, 2024

Unit Test Results

840 tests   840 ✅  22s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 015fc9e.

♻️ This comment has been updated with latest results.

Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
gei 81% 73% 578
ado2gh 84% 78% 627
Octoshift 86% 76% 1300
bbs2gh 79% 74% 680
Summary 84% (7081 / 8473) 76% (1613 / 2134) 3185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants