Skip to content

Commit

Permalink
chore: update linter (#2341)
Browse files Browse the repository at this point in the history
  • Loading branch information
ldez authored Nov 11, 2024
1 parent a7aaae4 commit c17ca37
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
env:
GO_VERSION: stable
GOLANGCI_LINT_VERSION: v1.60.1
GOLANGCI_LINT_VERSION: v1.62.0
HUGO_VERSION: 0.131.0
CGO_ENABLED: 0
LEGO_E2E_TESTS: CI
Expand Down
6 changes: 4 additions & 2 deletions .golangci.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
linters:
enable-all: true
disable:
- gomnd # deprecated
- cyclop # duplicate of gocyclo
- sqlclosecheck # not relevant (SQL)
- rowserrcheck # not relevant (SQL)
- execinquery # not relevant (SQL)
- lll
- gosec
- dupl # not relevant
Expand Down Expand Up @@ -255,6 +253,10 @@ issues:
text: 'cyclomatic complexity 13 of func `\(\*DNSProvider\)\.CleanUp` is high'
linters:
- gocyclo
- path: providers/dns/servercow/internal/types.go
text: 'the methods of "Value" use pointer receiver and non-pointer receiver.'
linters:
- recvcheck

# Those elements have been replaced by non-exposed structures.
- path: providers/dns/linode/linode_test.go
Expand Down
2 changes: 1 addition & 1 deletion providers/dns/auroradns/auroradns_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ func TestDNSProvider_Present(t *testing.T) {

reqBody, err := io.ReadAll(r.Body)
require.NoError(t, err)
assert.Equal(t, `{"type":"TXT","name":"_acme-challenge","content":"w6uP8Tcg6K2QR905Rms8iXTlksL6OD1KOWBxTK7wxPI","ttl":300}`, string(reqBody))
assert.JSONEq(t, `{"type":"TXT","name":"_acme-challenge","content":"w6uP8Tcg6K2QR905Rms8iXTlksL6OD1KOWBxTK7wxPI","ttl":300}`, string(reqBody))

w.WriteHeader(http.StatusCreated)
fmt.Fprintf(w, `{
Expand Down

0 comments on commit c17ca37

Please sign in to comment.