[PFX-811] - Tune Intl action #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agerard-godaddy
approved these changes
Nov 20, 2024
jpina1-godaddy
approved these changes
Nov 20, 2024
aryasaatvik
reviewed
Nov 22, 2024
| @@ -50,6 +50,10 @@ module.exports = async function buildManifest(gasket, options = {}) { | |||
| const keyName = importName | |||
| .replace(/\.json$/, '') | |||
| .replace('./', ''); | |||
| if (gasket.config.intl.experimentalImportAttributes) { | |||
There was a problem hiding this comment.
y'all should create a top level experimental/future flag which uses import asserts.
import as/from are executed at build time. createRequire is executed at runtime which makes it harder to run gasket in serverless environments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changelog
Test Plan
Updated