Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SIGUSR1 handler for sending SIGABRT to test run #346

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cmd/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@ const signalExitCode = 128

func newSignalHandler(ctx context.Context, pid int, p *proc) {
c := make(chan os.Signal, 1)
signal.Notify(c, os.Interrupt)
signal.Notify(c, os.Interrupt, syscall.SIGUSR1)

go func() {
defer signal.Stop(c)
Expand All @@ -497,6 +497,11 @@ func newSignalHandler(ctx context.Context, pid int, p *proc) {
log.Errorf("failed to find pid of 'go test': %v", err)
return
}

// send go test the SIGABRT signal to get a stack trace before exit
if ss, ok := s.(syscall.Signal); ok && ss == syscall.SIGUSR1 {
s = syscall.SIGABRT
}
if err := proc.Signal(s); err != nil {
log.Errorf("failed to interrupt 'go test': %v", err)
return
Expand Down