Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subset gene features by MAD and clean up data preprocessing code #10

Merged
merged 12 commits into from
Aug 11, 2020

Conversation

jjc2718
Copy link
Member

@jjc2718 jjc2718 commented Aug 10, 2020

This PR does the following:

See README.md for a description of the project. Happy to discuss/answer questions/add clarification if what I'm doing here is unclear.

@jjc2718 jjc2718 requested a review from miltondp August 10, 2020 14:36
Copy link
Member

@miltondp miltondp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jake, the code looks good, so I'm approving these changes. I left some minor comments.

pancancer_utilities/data_utilities.py Show resolved Hide resolved
pancancer_utilities/data_utilities.py Outdated Show resolved Hide resolved
pancancer_utilities/data_utilities.py Outdated Show resolved Hide resolved
pancancer_utilities/data_utilities.py Outdated Show resolved Hide resolved
pancancer_utilities/data_utilities.py Show resolved Hide resolved
pancancer_utilities/scripts/classify_cancer_type.py Outdated Show resolved Hide resolved
pancancer_utilities/tcga_utilities.py Show resolved Hide resolved
pancancer_utilities/tcga_utilities.py Outdated Show resolved Hide resolved
@jjc2718 jjc2718 merged commit 5c96290 into greenelab:master Aug 11, 2020
@jjc2718 jjc2718 deleted the bug_fixes branch August 11, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix cancer type covariate when single cancer is held out Implement subsetting genes by MAD
2 participants