This repository has been archived by the owner on Jul 16, 2019. It is now read-only.
iOS 10 Support & Fix Transparency #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re-creating transparency next
edgesForExtendedLayout was forcing the table/collection view to be lower than the navigation bar preventing transparency from ever working, and the background image / shadow image navigation bar code was creating an issue when the edge layout was removed you could see the content on top of the status bar.
added the backgroundColor for the toolbar and the barTintColor for the navigation bar, since backgroundColor and barTintColor behave slightly differently for how the color of the bar is affected
The apple default is nil and the transparency can be seen much better. The white tint / background actually affects how much the transparency can show through.
…round The current clear color creates an issue where the text is seen on top of the image collection with no seperation. It would be better to at least match the picker color background so the headers are legible as you scroll.
|
Fixes #54 |
patelhiren
pushed a commit
to patelhiren/GMImagePicker
that referenced
this pull request
Aug 8, 2016
Merging changes from guillermomuntaner#56 Which are not merged with the main branch yet.
|
Can we get this merged? |
|
For anyone else who needs the fix right now: Thanks @sarafrederixon! |
|
@guillermomuntaner can you merge this? |
AnumQ
suggested changes
Oct 20, 2016
|
@AnumQ what error are you getting? I didn't change this line so curious on what is happening for you. |
|
This bug occurred last week and it was gone when I checked again on Friday. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was tested on iOS 9.3 iPhone 6 & iPod touch, iOS 10 beta 3 iPhone 6s, and iOS 10 public beta 1 iPad Air