ci: build and test with Go 1.23 #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #871 +/- ##
==========================================
+ Coverage 61.46% 66.41% +4.94%
==========================================
Files 238 242 +4
Lines 8548 8727 +179
==========================================
+ Hits 5254 5796 +542
+ Misses 2582 2218 -364
- Partials 712 713 +1 ☔ View full report in Codecov by Sentry. |
apricote
approved these changes
Sep 16, 2024
apricote
approved these changes
Sep 18, 2024
This was referenced Sep 30, 2024
phm07
added a commit
to hetznercloud/packer-plugin-hcloud
that referenced
this pull request
Sep 30, 2024
This PR updates the Go version used in our CI to Go 1.23. See hetznercloud/cli#871 for a previous discussion.
phm07
added a commit
to hetznercloud/terraform-provider-hcloud
that referenced
this pull request
Sep 30, 2024
This PR updates the Go version used in our CI to Go 1.23. See hetznercloud/cli#871 for a previous discussion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the CI pipeline use Go 1.23 for building and testing. Only setting the
toolchainingo.modis not enough, because the setup-go action does not support thetoolchaindirective yet, we have to set the Go version to 1.23 in all setup-go CI steps manually.We could also set the
goversion ingo.modto 1.23 since we do not have any dependents, but that would be misusing thegodirective, since it is only intended to specify the minimum supported language version of the project.