Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VideoCrafter as a library #805

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add VideoCrafter as a library #805

wants to merge 3 commits into from

Conversation

NielsRogge
Copy link
Contributor

@NielsRogge NielsRogge commented Jul 16, 2024 •
edited
Loading

Wauplin
Wauplin reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NielsRogge! I've left some comments, feel free to adapt if you think it's relevant.

Regarding the PRs you've opened on the Hub, would it be possible to update them to add pipeline_tag=text-to-video or pipeline_tag=image-to-video as well? This is kinda orthogonal but would help with model discoverability.

packages/tasks/src/model-libraries.ts Outdated Show resolved Hide resolved
packages/tasks/src/model-libraries-snippets.ts Outdated Show resolved Hide resolved
packages/tasks/src/model-libraries.ts Show resolved Hide resolved
@Wauplin Wauplin mentioned this pull request Jul 17, 2024
Open
4 tasks
@NielsRogge NielsRogge mentioned this pull request Jul 17, 2024
Open
Wauplin
Wauplin approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR LGTM, thanks @NielsRogge!

As mentioned in #805 (review) I think it would be good to update the PRs mentioned in the description to add a pipeline_tag for discoverability.

Also, https://huggingface.co/VideoCrafter/Text2Video-256/discussions/1 seems to be an empty PR.

Let's merge this once Hub PRs are finalized and merged :)

@osanseviero
Copy link
Contributor

Yes let's add pipeline_tag 🙏

@NielsRogge
Copy link
Contributor Author

Thanks, waiting for the author to merge the PRs before merging this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wauplin Wauplin Wauplin approved these changes

@osanseviero osanseviero Awaiting requested review from osanseviero

@SBrandeis SBrandeis Awaiting requested review from SBrandeis SBrandeis is a code owner

@gary149 gary149 Awaiting requested review from gary149 gary149 is a code owner

@julien-c julien-c Awaiting requested review from julien-c julien-c is a code owner

@pcuenca pcuenca Awaiting requested review from pcuenca pcuenca is a code owner

@ngxson ngxson Awaiting requested review from ngxson ngxson is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NielsRogge @osanseviero @Wauplin