Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete widgets code #902

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Delete widgets code #902

wants to merge 2 commits into from

Conversation

osanseviero
Copy link
Contributor

The code from widgets has been moved back to internal. Having it duplicated has led to confusion with the icons and widgets, so this PR proposes to delete all of it

@julien-c
Copy link
Member

julien-c commented Sep 12, 2024

i think @coyotte508 left it on purpose (as a reference for anyone in the community who could play with it) but idk

@julien-c
Copy link
Member

There is a big Note: this package is no longer maintained. it should be enough for our team members no?

Copy link
Member

@coyotte508 coyotte508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we had someone make a contribution to the outdated widgets (a bug fix), it was helpful, we ported it internally

but yes, ok to remove 😢

@osanseviero
Copy link
Contributor Author

Up to you if you really think it's good to keep up, but we should prevent issues such as people adding icons here and not in the internal code or adding widgets here (#732 or #870)

as a reference for anyone in the community who could play with it

For this I guess we should automatically update the external one, right?

@julien-c
Copy link
Member

internal team members it's pretty easy to tell them no?

@osanseviero
Copy link
Contributor Author

Sure but does save work. New one #953

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants