-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete widgets code #902
base: main
Are you sure you want to change the base?
Delete widgets code #902
Conversation
i think @coyotte508 left it on purpose (as a reference for anyone in the community who could play with it) but idk |
There is a big |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we had someone make a contribution to the outdated widgets (a bug fix), it was helpful, we ported it internally
but yes, ok to remove 😢
Co-authored-by: Eliott C. <[email protected]>
Up to you if you really think it's good to keep up, but we should prevent issues such as people adding icons here and not in the internal code or adding widgets here (#732 or #870)
For this I guess we should automatically update the external one, right? |
internal team members it's pretty easy to tell them no? |
Sure but does save work. New one #953 |
The code from widgets has been moved back to internal. Having it duplicated has led to confusion with the icons and widgets, so this PR proposes to delete all of it