feat(server): Remove concurrency limit built in feature #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shikhar
reviewed
Oct 5, 2024
| @@ -173,6 +173,10 @@ impl<L> Server<L> { | |||
| /// builder.concurrency_limit_per_connection(32); | |||
| /// ``` | |||
| #[must_use] | |||
| #[deprecated( | |||
| since = "0.12.4", | |||
| note = "Use `layer()` with a layer which provide concurrency limit feature such as `tower::limit::ConcurrencyLimitLayer` used in this config." | |||
There was a problem hiding this comment.
I don't think that will provide 'per connection' concurrency-limiting semantics like this purports to.
There was a problem hiding this comment.
Makes sense. Seems necessary to add functionality to set layers for the purpose.
There was a problem hiding this comment.
I think that would be helpful, see e.g. #1616
(interpreting your comment as: purpose == per connection)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes concurrency limit build in feature. As the server is composable with tower's services, this seems not to be needed to be built in.