Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tls): Add rustls-platform-verifier support #1974

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(tls): Add rustls-platform-verifier support #1974

wants to merge 1 commit into from
+33 −0

Conversation

tottoto
Copy link
Collaborator

@tottoto tottoto commented Oct 5, 2024

Adds rustls-platform-verifier support.

@tottoto
Copy link
Collaborator Author

tottoto commented Oct 5, 2024

These are needed for macos and windows.

rustls/rustls-platform-verifier#133
rustls/rustls-platform-verifier#135

@tottoto tottoto force-pushed the add-rustls-platform-verifier-support branch from 100f8a1 to bdbc78b Compare October 10, 2024 14:54
@tobz
Copy link
Collaborator

tobz commented Oct 22, 2024

It would be good to get @djc's thoughts here, since the benefits listed by rustls-platform-verifier itself seem good, albeit small... and it's not clear to me if there are more and/or worse platform support caveats using this vs sticking with rustls-native-certs.

@tobz tobz added C-enhancement Category: New feature or request I-needs-decision Issues in need of decision. labels Oct 22, 2024
@djc
Copy link
Contributor

djc commented Oct 22, 2024 •
edited
Loading

As @tottoto suggested in a previous comment (thought it might not be quite clear), released versions of rustls-platform-verifier don't have all the API in place to support additivity with native-roots and webpki-roots across platforms, so might want to wait for that. The rustls project recommends ~all users migrate away from rustls-native-certs to using the rustls-platform-verifier.

rustls/rustls-platform-verifier#148

@tottoto tottoto force-pushed the add-rustls-platform-verifier-support branch from bdbc78b to cd9131c Compare October 27, 2024 06:40
@tottoto tottoto force-pushed the add-rustls-platform-verifier-support branch from cd9131c to 0788dc2 Compare October 27, 2024 06:41
@tottoto tottoto marked this pull request as draft November 7, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C-enhancement Category: New feature or request I-needs-decision Issues in need of decision.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tottoto @tobz @djc