feat: integrate storybook with chromatic #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #428 +/- ##
========================================
Coverage 97.99% 97.99%
========================================
Files 69 69
Lines 1443 1443
Branches 279 279
========================================
Hits 1414 1414
Misses 29 29 |
kyoyadmoon
force-pushed
the
ci/integrate-chromatic
branch
from
2dd2f95
to
da01344
Compare
kyoyadmoon
force-pushed
the
ci/integrate-chromatic
branch
from
da01344
to
10edbcc
Compare
kyoyadmoon
force-pushed
the
ci/integrate-chromatic
branch
from
10edbcc
to
3b53155
Compare
kyoyadmoon
force-pushed
the
ci/integrate-chromatic
branch
from
3b53155
to
dd911b8
Compare
|
tz5514
approved these changes
Jan 31, 2024
chenesan
approved these changes
Feb 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Asana
Storybook Preview
整合 Chromatic，把文件從 Netlify 換到 Chromatic 上
因為改了原本輸出 static files 的資料夾 (改成 Storybook 的預設值
storybook-static)，Netlify 的 CI 會失敗是預期的