Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to drag rows even when user click to not "TD" node #94

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kkozlik
Copy link

@kkozlik kkozlik commented Feb 8, 2019

fix #93

@brendon
Copy link
Collaborator

brendon commented Feb 10, 2019

THanks @kkozlik, @isocra, can you remember why you're only allowing the TD to be dragged?

@isocra
Copy link
Owner

isocra commented Feb 18, 2019

Hi @brendon, I can't remember off the top of my head why it's the case. I remember that it was quite tricky to cells that have complex html in them (e.g. nested tables). Do all the example tables still work with this change?

@brendon
Copy link
Collaborator

brendon commented Feb 18, 2019

Thanks @isocra, looking at https://github.com/SortableJS/Sortable they disable text selection (aka allow the whole row to be dragged) unless a handle is defined. I guess @kkozlik, if you can check that nested tables etc... work with this change, and that the .handle functionality still works (and allows text selection and link clicking etc... on the non-handles then I guess this one is ok to merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dragging do not work if table cell contain HTML elements
3 participants