Allow leading logical operators #5407
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+757
to
+760
| # Returns `yes` if standing in front of what will become a LEADING_AND or | ||
| # LEADING_OR, ie TERMINATOR followed by && or || | ||
| isLeadingLogical: (i) -> | ||
| @tag(i) is 'TERMINATOR' and @tag(i + 1) in LEADING_LOGICAL |
There was a problem hiding this comment.
I would think that you shouldn’t need to use the rewriter for this. The regular lexer often looks multiple tokens ahead; whenever it sees an and/or token followed by a terminator, it could create it as LEADING_AND or LEADING_OR in the first place rather than needing the rewriter to make another pass.
In general everything in rewriter.coffee is hacks that are unfortunate workarounds, and we want to avoid adding to the rewriter if at all possible. Each rewrite pass adds a performance hit to compilation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #5279