Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ci #5478

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix ci #5478

wants to merge 5 commits into from

Conversation

cosmicexplorer
Copy link
Contributor

@cosmicexplorer cosmicexplorer commented Nov 26, 2024

This PR builds off of #5463 to get main passing CI again.

Closes #5463.

Changes:

  • pin architecture: x64 for our node runners to fix the error setup-node has developed when resolving for macos-latest with architecture arm64
  • add a global skip symbol to skip tests, and skip a few tests around stack traces and source maps which have begun to error
  • update copyright dates to span to 2024 in generated doc output
  • remove 12.x node version from our matrix, as it is EOL as of April 2022: https://nodejs.org/en/blog/release/v12.13.0

@cosmicexplorer cosmicexplorer marked this pull request as ready for review November 26, 2024 21:41
@cosmicexplorer
Copy link
Contributor Author

cc @deining @GeoffreyBooth: I got the macOS shards to work again by explicitly specifying the x64 architecture (the shards are "queued" now likely because I restarted them several times, but they should work). I also found that node 12.x is EOL, so felt it should be reasonable to remove. However I also had to skip some tests, which are clearly marked by calling skip instead of test; the new skip symbol prints a warning to the console and avoids executing the body of the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants