Saving generated emails locally #29

mborger · 2016-02-05T05:47:14Z

Added an option to save the generated emails locally instead of sending through an SMTP server. This is useful if you're signing keys from an air gapped machine.

jaymzh · 2016-02-05T07:33:20Z

You then just hand these to postfix or sendmail or whatever?

I'd been asked for a similar feature, but had been planning it differently - write out the signatures and some metadata, and then have another option to slurp that in and send them off...

I'm not entirely sure which I like better.

Your approach is definitely simpler and less code. Less to keep track of, less to refactor. The downside is that it requires more know-how on the part of the user to then send those messages off... for example, at the very least you have to have a mailserver configured to send properly - which many don't (which is why pius can speak to remote mailservers directly with auth).

Let me ponder it it for a bit. I'll get back to you. :)

mborger · 2016-02-05T08:29:12Z

Yup, I transferred the emails to my mail server and handed each of them off to sendmail.
for f in $(ls); do sendmail -t < $f; done
The -t option just tells sendmail to use the header fields for the recipient and sender information instead of specifying them on the commandline.

I see your point that a fair number of people don't have an MTA setup for this to work. If you don't want to add another mode to Pius for just sending the generated emails, perhaps we can get mailx to send the emails in a fashion similar to sendmail. This is what I have so far but it doesn't seem to be pulling the recipients out of the email metadata like sendmail does.
mailx -t -S smtp="mail.example.com:25" -S smtp-auth=login -S smtp-auth-user="[email protected]" -S smtp-auth-password="password" < emailFile

jaymzh · 2016-02-29T09:12:34Z

libpius/mailer.py

+          # must re-ehlo after STARTTLS
+          smtp.ehlo()
+          # Don't want to send auth information unless we're TLS'd
+          if self.user:


The more I think about this approach the more I like it.

However... how do we handle the email_override and the BCC-the-user bit here?

Sorry for the extremely late reply. I think these options can be handled by moving their logic to the beginning of the add_options method. Then they will be printed out to the email file or passed to sendmail.

But you aren't actually writing it to the file... env_to isn't in the object you write out.

Yeah, keeping py2 compat for now. BUt also as mentioned I think we should only add that Bcc header to the message when we're saving it as a proxy for a proper envelope header.

jaymzh · 2018-01-14T20:49:39Z

@mborger - you still interested in finishing this?

mborger · 2018-01-16T05:36:06Z

Sure. What's next on your mind to look into?

jaymzh · 2018-01-16T09:07:53Z

I think all that's left is:

Documentation on how to hand this to an MTA
the ability to handle email_override and the BCC-the-user options
rebase on current master

And then we're good.

mborger · 2018-01-17T06:32:50Z

Check out my changes. I combined the two address override conditionals to the beginning of the _send_mail method.

jaymzh · 2018-01-18T07:01:54Z

libpius/mailer.py

+      if not os.path.isdir(self.local_mail_dir):
+        os.mkdir(self.local_mail_dir)
+      email = open(os.path.join(self.local_mail_dir, msg['To']), 'w')
+      email.write(str(msg))


the env_to isn't being written here...

Good catch but this opens another question. Do we need the copy to yourself to be blind? There is no standard for a BCC header within an email that a sender is supposed to strip before the SMTP submission. We could look into finding a client that does that or add another command to pius to handle sending these emails. If we don't really need the self copy to be blind then we can just add the extra To header to the message and mail senders should send it to both addresses.

Well, sendmail's -t does this. It reads all address headers from the message (to,cc,bcc), acts on them and strips out BCC from the message.

I just tried postfix'q sendmail compat mode, and it also does this.

So... that's probably sufficient.

I would say that if the mailqueue mode is activated, take any env_tos that are not in the standard to and add them as Bcc in the message.

I added a Bcc header and included a helper function to generate the to_addrs parameter of the send_mail method. Newer versions of python have a send_message method which will extract the headers from the message. I included it with some comments but I think you're still trying to support Python2.

jaymzh · 2018-01-22T08:21:08Z

doc/pius.1

@@ -47,6 +47,8 @@ Hostname of SMTP server. [default: \fIlocalhost\fP]
 Use the pexpect module for signing and drop to the gpg shell for entering the passphrase. [default: false]
 .IP "\fB\-I\fP, \fB\-\-import\fP"
 Also import the unsigned keys from the keyring into the default keyring. Ignored if \fB\-r\fP is not specified, or if it's the same as the default keyring.
+.IP "\fB\-L\fP, \fB\-\-local\-mail\-dir\fP"


We should probably call this --save-to-mail-dir or something

Changed to --save-to-mail-dir

jaymzh · 2018-01-22T08:38:18Z

libpius/mailer.py

+      if not os.path.isdir(self.local_mail_dir):
+        os.mkdir(self.local_mail_dir)
+      email = open(os.path.join(self.local_mail_dir, msg['To']), 'w')
+      email.write(str(msg))


Well, sendmail's -t does this. It reads all address headers from the message (to,cc,bcc), acts on them and strips out BCC from the message.

I just tried postfix'q sendmail compat mode, and it also does this.

So... that's probably sufficient.

I would say that if the mailqueue mode is activated, take any env_tos that are not in the standard to and add them as Bcc in the message.

jaymzh · 2018-01-23T06:39:11Z

libpius/mailer.py

    else:
      msg['To'] = to
-      env_to = [to, self.mail]
+      msg['BCC'] = self.mail


I think that should be Bcc

jaymzh · 2018-01-23T06:40:35Z

libpius/mailer.py

@@ -256,38 +258,50 @@ def _send_mail(self, to, msg):
      msg['To'] = self.address_override
    else:
      msg['To'] = to
+      msg['Bcc'] = self.mail


we should only do this in the case of self.local_mail_dir

jaymzh · 2018-01-28T22:56:11Z

@mborger - This code looks great! Thanks for working through the long review process on this one. The only thing left before merging is some docs. Probably a simple command people can run to send off all the emails, in the help for -L is sufficient, but I"m also open to a separate doc explaining the use-case.

to a given folder instead of sending via SMTP.

jaymzh · 2018-03-19T01:25:38Z

Hey @mborger - wanna rebase and add some simple comments to the README on this and I can merge it?

jaymzh · 2018-03-24T00:41:27Z

@mborger ?

abrahamcuenca · 2020-03-07T06:29:17Z

Looks like this PR grew a bit stale. Should it be closed?

jaymzh · 2020-03-09T23:41:05Z

one last call, @mborger ?

jaymzh reviewed Feb 29, 2016
View reviewed changes

mborger force-pushed the localMail branch 2 times, most recently from df7299c to fb7b273 Compare January 17, 2018 06:30

jaymzh requested changes Jan 18, 2018

View reviewed changes

jaymzh requested changes Jan 22, 2018

View reviewed changes

mborger force-pushed the localMail branch from da7e8b2 to 53537f7 Compare January 23, 2018 06:41

jaymzh requested changes Jan 23, 2018

View reviewed changes

mborger force-pushed the localMail branch 2 times, most recently from e2562c9 to 6987bca Compare January 24, 2018 05:46

Added option to save generated emails

0afeb2f

to a given folder instead of sending via SMTP.

mborger force-pushed the localMail branch from 6987bca to 0afeb2f Compare February 7, 2018 06:29

jaymzh mentioned this pull request Mar 19, 2018

allow sending mail via external programs #65

Open

cbrownstein mentioned this pull request Apr 11, 2018

Add option to save generated emails #92

Open

jaymzh added the waitingonsubmitter Waiting on the sbumitter label Sep 21, 2018

jaymzh self-assigned this Sep 21, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Saving generated emails locally #29

Saving generated emails locally #29

mborger commented Feb 5, 2016

jaymzh commented Feb 5, 2016

mborger commented Feb 5, 2016

jaymzh Feb 29, 2016

jaymzh Oct 15, 2016

mborger Feb 16, 2017

jaymzh Jan 18, 2018

jaymzh Jan 23, 2018

jaymzh commented Jan 14, 2018

mborger commented Jan 16, 2018

jaymzh commented Jan 16, 2018

mborger commented Jan 17, 2018

jaymzh Jan 18, 2018

mborger Jan 21, 2018

jaymzh Jan 22, 2018

mborger Jan 23, 2018

jaymzh Jan 22, 2018

mborger Jan 23, 2018

jaymzh Jan 22, 2018

jaymzh Jan 23, 2018

jaymzh Jan 23, 2018

jaymzh commented Jan 28, 2018

jaymzh commented Mar 19, 2018

jaymzh commented Mar 24, 2018

abrahamcuenca commented Mar 7, 2020

jaymzh commented Mar 9, 2020

Saving generated emails locally #29

Are you sure you want to change the base?

Saving generated emails locally #29

Conversation

mborger commented Feb 5, 2016

jaymzh commented Feb 5, 2016

mborger commented Feb 5, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jaymzh commented Jan 14, 2018

mborger commented Jan 16, 2018

jaymzh commented Jan 16, 2018

mborger commented Jan 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jaymzh commented Jan 28, 2018

jaymzh commented Mar 19, 2018

jaymzh commented Mar 24, 2018

abrahamcuenca commented Mar 7, 2020

jaymzh commented Mar 9, 2020