Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config writeback comments #177

Open
natopotato390 opened this issue Jan 22, 2024 · 1 comment
Open

Remove config writeback comments #177

natopotato390 opened this issue Jan 22, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@natopotato390
Copy link

Using release 2.1.0 on PaperMC

Great plugin, does what I need. One small annoyance,

It would be nice to be able to put multiple motd's in the config like this:

icon-enabled=false
motds=[
    {
        line1="SandCraft"
        line2="This is a motd!"
    },
    {
        line1="SandCraft"
        line2="This is another motd!"
    }
]

...without it being changed by the plugin on server startup to this:

icon-enabled=false
motds=[
    {
		# Set the icon to use with this MOTD
        #  Either use 'random' to randomly choose an icon, or use the name
        #  of a file in the icons folder (excluding the '.png' extension)
        #    ex: icon="myIconFile"
        icon=random
        line1="SandCraft"
        line2="This is a motd!"
    },
    {
		# Set the icon to use with this MOTD
        #  Either use 'random' to randomly choose an icon, or use the name
        #  of a file in the icons folder (excluding the '.png' extension)
        #    ex: icon="myIconFile"
        icon=random
        line1="SandCraft"
        line2="This is another motd!"
    }
]

When your server has a lot of different motd's it becomes a hassle to go back in later and edit things with this wall of text between EVERY message.

Any of the values (like icon= or line2=) should also be able to be omitted without it being added back in automatically.

@natopotato390 natopotato390 added the enhancement New feature or request label Jan 22, 2024
@ltjessem
Copy link

ltjessem commented Feb 7, 2024

Wholeheartedly agree. In addition to this, imagine how happy I was to have backups when I commented out all my MOTDs temporarily, and the plugin straight up deleted the commented out lines.
I'd label this a straight up bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants