Add opendev.org https and git fetcher

[ryan-beisner]

Related to #552
https://bugs.launchpad.net/charm-barbican/+bug/1846263

[ryan-beisner]

Ready for review.

Just to confirm, I did a rebuild of the previously offending charm, and the build succeeds with this branch of charmtools.

charmtools.build.tactics: Copying Interface hacluster: /home/beisner/git/release-tools.round6/barbican/build/builds/barbican/hooks/relations/hacluster
charmtools.build.tactics: Copying Interface openstack-ha: /home/beisner/git/release-tools.round6/barbican/build/builds/barbican/hooks/relations/openstack-ha
charmtools.build.tactics: Copying Interface barbican-hsm: /home/beisner/git/release-tools.round6/barbican/build/builds/barbican/hooks/relations/barbican-hsm
charmtools.build.tactics: Copying Interface barbican-secrets: /home/beisner/git/release-tools.round6/barbican/build/builds/barbican/hooks/relations/barbican-secrets
charmtools.build.tactics: Trying to determine version with: git
utils: b'1b6e560-dirty\n'
utils: process: git describe --dirty --always (0)
charmtools.build.tactics: Got version: 1b6e560-dirty
build: Cleaning up /home/beisner/.cache/charm/7721
proof: I: `display-name` not provided, add for custom naming in the UI
proof: I: No icon.svg file.
proof: I: all charms should provide at least one thing
proof: I: config.yaml: option ssl_cert has no default value
proof: I: config.yaml: option ssl_key has no default value
proof: I: config.yaml: option ssl_ca has no default value
proof: I: config.yaml: option os-admin-network has no default value
proof: I: config.yaml: option os-internal-network has no default value
proof: I: config.yaml: option os-public-network has no default value
proof: I: config.yaml: option os-public-hostname has no default value
proof: I: config.yaml: option os-internal-hostname has no default value
proof: I: config.yaml: option os-admin-hostname has no default value
proof: I: config.yaml: option worker-multiplier has no default value
proof: I: config.yaml: option haproxy-server-timeout has no default value
proof: I: config.yaml: option haproxy-client-timeout has no default value
proof: I: config.yaml: option haproxy-queue-timeout has no default value
proof: I: config.yaml: option haproxy-connect-timeout has no default value
proof: I: config.yaml: option vip has no default value
________________________________________________________________________________________ summary _________________________________________________________________________________________
  build: commands succeeded
  congratulations :)
beisner@rby:~/git/release-tools/barbican$ 

[thedac]

The change looks good.

Out of scope of this change, the classes look like they are calling out for some refactoring and inheritance to avoid boilerplate duplicate code.

[johnsca]

There's a lot of duplicated implementation between GitFetcher, GitHubFetcher, LaunchpadGitFetcher, and OpendevFetcher. I think it would be good to refactor this so that they all subclass from GitFetcher and extend as needed to reduce duplicated code. (For example, the GitFetcher is currently missing the revision handling that was added to the others.)

[johnsca]

My previous comment was not intended as a nack, just to call out that this section of code could really use some cleaning up at some point. PR is fine as-is for the immediate fix.

[johnsca]

2.7.2 has been released to PyPI with (only) this change.

[ryan-beisner]

@johnsca 😸 Thanks!