Upgrade setuptools #667
Merged
Upgrade setuptools #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setuptools-scm depends on setuptools>=61, while the one installed in the building environment is setuptools-59.x which comes from the deb package available in Ubuntu-22.04. This change upgrades setuptools to allow the building to succeed. Also uses an absolute path when running `vergit` to fix a "command not found" error. Fixes juju#666
|
This is the output of building charm-tools snap in a aarch64 machine https://pastebin.ubuntu.com/p/WQwzFphm7y/ |
ajkavanagh
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setuptools-scm depends on setuptools>=61, while the one installed in the building environment is setuptools-59.x which comes from the deb package available in Ubuntu-22.04.
This change upgrades setuptools to allow the building to succeed. Also uses an absolute path when running
vergitto fix a "command not found" error.Fixes #666
Description of change
Checklist
make test?