Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QIcon::fromTheme
start returning icons on macOS. There was already code to mostly turn off the icons, but it only affected the window menus. If you close all windows and were left with just the application's global menu bar or whatever it's called, icons were showing there. This also causes a serious delay any time a window is opened or closed, since something about menu icons in macOS on Qt is really slow and they don't get cached properly (remember we worked around that in the past for the Open With / Recent submenus). It looks like a later change, qt/qtbase@d671e1a, will hide menu icons by default on macOS, but my commit will ensure things work as intended with Qt 6.7.0 - Qt 6.7.2 if someone compiles qView for those versions.