Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future Qt compatibility #695

Merged
merged 3 commits into from
Oct 12, 2024
Merged

Future Qt compatibility #695

merged 3 commits into from
Oct 12, 2024

Conversation

jdpurcell
Copy link
Contributor

  1. Limit workaround for QTBUG-125380 which was fixed in 6.7.2.
  2. qt/qtbase@9bbfdd6 made QIcon::fromTheme start returning icons on macOS. There was already code to mostly turn off the icons, but it only affected the window menus. If you close all windows and were left with just the application's global menu bar or whatever it's called, icons were showing there. This also causes a serious delay any time a window is opened or closed, since something about menu icons in macOS on Qt is really slow and they don't get cached properly (remember we worked around that in the past for the Open With / Recent submenus). It looks like a later change, qt/qtbase@d671e1a, will hide menu icons by default on macOS, but my commit will ensure things work as intended with Qt 6.7.0 - Qt 6.7.2 if someone compiles qView for those versions.
Screenshot 2024-07-05 at 6 28 49 PM
  1. qt/qtbase@fd97a82 implements a "safe area margin" concept on macOS which breaks qView's full size content view feature. With Qt 6.8 beta, this results in the graphics view widget not being placed under the titlebar as intended, meaning the cool translucent effect with the image underneath the titlebar doesn't work, and when fitting the image, the calculation is broken leaving a gap at the top. My commit opts out of this "safe area margin" feature.
Screenshot 2024-07-05 at 6 31 15 PM

Starting Qt 6.7, QIcon::fromTheme returns icons even on macOS. This code already attempted to hide them, but did so too late to affect the parentless menubar.
@jurplel
Copy link
Owner

jurplel commented Oct 12, 2024

Amazingly researched, documented, split into commits, as always. Reviewing is a joy

@jurplel jurplel merged commit 26aa460 into jurplel:master Oct 12, 2024
7 checks passed
@jdpurcell jdpurcell deleted the pr-qtfuture branch October 16, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants