Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a partSize parameter. #537

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

maobaolong
Copy link

By this parameter, we can specify a customized partSize.

@@ -187,11 +187,11 @@ func (fh *FileHandle) partSize() uint64 {
var size uint64

if fh.lastPartId < 1000 {
size = 5 * 1024 * 1024
size = fh.inode.fs.flags.MPUPartSize
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This behavior may confuse users. Instead, how about using a fixed size when provided by the flag and this gradually increasing size when not provided?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, we can further discussing this after we accept this proposal

@kahing
Copy link
Owner

kahing commented Aug 24, 2020

Could you explain what's the motivation of configuring the part size?

@maobaolong
Copy link
Author

@kahing Now Ozone use Goofys as a fuse interface, Goofys talk to Ozone s3gateway now, but there are a performance issue when the partSize is not suitable to Ozone chunkSize, now Ozone chunk is 4MB, and goofys partSize is 5MB, so it will cost two time read Chunk when read file, If we set the partSize to 8MB, when read this part, two time read chunk can read 8MB from ozone datanode, with this feature, we can improve 3x read performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants