-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove is-gen-fn dependency #130
base: master
Are you sure you want to change the base?
Conversation
The is-gen-fn package causes a DeprecationWarning with Node 16; since it is fairly trivial, just include the generator function check here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have replaced the is-gen-fn
with is-generator-function
here #128 and it available in the next release when the merge happened.
Ah, I did glance at the open issues, but didn't look closely at the open PRs! Alright, feel free to close this, then (unless you maybe want to merge it as a temporary fix, since it could be released as a patch version until #128 lands). |
The |
Any updates regarding this PR? Would also love to use it without the deprecation warning |
Updates: For now, you can use |
Hi @3imed-jaberi, is there anything new for this PR, I created another PR for this: #137 |
@3imed-jaberi hello, is this package currently still under maintenence ? |
Hey Guys, next week we will publish the latest version (including the latest fixed) under
|
The is-gen-fn package causes a DeprecationWarning with Node 16:
Since it is fairly trivial, just include the generator function check here.