KTOR-7845 Fix for threading issue in flushAndClose for reader job channels #4503
+53
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Core, I/O
Motivation
KTOR-7845 File is not commited after closing writeChannel() of the file
Solution
The problem here is that
flushAndClose()
doesn't wait for theReaderJob
to finish so it has no effect on the final destination of the data. By adding a hook to wait for the job to complete, we can daisy chain these jobs with some trust thatflushAndClose()
will work properly from the perspective of the caller.For reference, here is the
writeChannel
utility function: