Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to API server dashboard #245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lnovara
Copy link

@lnovara lnovara commented Aug 27, 2019

This PR improves the API server dashboard by adding minimums to Y-axis of every plot and moving the singlestat panel on its own row to give the dashboard a more homogeneous structure.

@brancz
Copy link
Member

brancz commented Aug 28, 2019

cc @povilasv

@lnovara
Copy link
Author

lnovara commented Aug 28, 2019

@brancz @povilasv There are also other minor issues like these in the other dashboards, do you want me to address them in separate PRs or we can pack everything into this one?

Thank you.

@brancz
Copy link
Member

brancz commented Aug 28, 2019

I'd say let's do small separate PRs. Also it would help immensely if you could attach a screenshot of before after, if it's not too much trouble :)

@lnovara
Copy link
Author

lnovara commented Aug 28, 2019

Thank you @brancz, I will open other PRs.

Meanwhile, here you have the before and after screenshots of the dashboard:

Before:

After:

@povilasv
Copy link
Contributor

I'm not sure whether it makes sense to make up have a separate row, as those dashboards are quite a long already.

Other changes LGTM

@brancz
Copy link
Member

brancz commented Aug 28, 2019

Agreed regarding the up panel.

Copy link

This PR has been automatically marked as stale because it has not
had any activity in the past 30 days.

The next time this stale check runs, the stale label will be
removed if there is new activity. The issue will be closed in 7
days if there is no new activity.

Thank you for your contributions!

@github-actions github-actions bot added the stale label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants