-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kep for LQ defauling #3652
base: main
Are you sure you want to change the base?
Add kep for LQ defauling #3652
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yaroslava-serdiuk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
efc4dd2
to
be70ff5
Compare
|
||
- create a default LocalQueue. | ||
|
||
## Proposal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we clarify what CQ does the default LQ will refer to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The admin creates a default LQ manually, so they will specify CQ.
The feature only add default
LQ to the job if it exists in the namespace.
manageJobsWithoutQueueName doesn't work with this feature, since Kueue add the LocalQueue | ||
annotation. | ||
|
||
### Risks and Mitigations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this proposal results in every Job created in a namespace will be managed by Kueue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the feature gate is enabled and default
LQ is created in a namespace, then yes.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
issue #2936
Does this PR introduce a user-facing change?
cc: @mimowo @mwielgus @PBundyra