Move logs to blob from Cosmos #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjcollinge
reviewed
Jul 26, 2018
| @@ -455,7 +424,7 @@ func getLogsForTask(ctx context.Context, fileClient *batch.FileClient, t *batch. | |||
| sb := strings.Builder{} | |||
| //Log the details from the running task | |||
| logs, err := getLogFileContent(ctx, t, fileClient, jobID, "stdout.txt") | |||
| sb.WriteString("\n\n ------ Batch logs: stdout ------ \n\n") //nolint: errcheck | |||
| sb.WriteString("\n\n ------ [Debug] Batch logs: stdout ------ \n\n") //nolint: errcheck | |||
There was a problem hiding this comment.
The [DEBUG] heading does not necessarily match the error level (warnings are used) which might be confusing.
| sb.WriteString("\n\n ------ Commit logs ------ \n\n") //nolint: errcheck | ||
| if err != nil { | ||
| log.WithError(err).WithField("task", *t).Warningf("failed to get %v from task", "stout") | ||
| sb.WriteString("failed to get %v from task: stdout") //nolint: errcheck |
There was a problem hiding this comment.
What interpolates %v here?
| sb.WriteString("\n\n ------ Preparer logs ------ \n\n") //nolint: errcheck | ||
| if err != nil { | ||
| log.WithError(err).WithField("task", *t).Warningf("failed to get %v from task", "stout") | ||
| sb.WriteString("failed to get %v from task: stdout") //nolint: errcheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#130