Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kanvas Icon In Navigation Menu #6037

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Tharanishwaran
Copy link
Member

Description

Replace Old MeshMap Icon with New Kanvas Logo in Navigation Menu

This PR fixes #6032

Notes for Reviewers

Screenshots

Screenshot from 2024-10-27 23-48-39

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Tharanishwaran <[email protected]>
@Tharanishwaran Tharanishwaran changed the title Updated Kanvas Hexagonal Icon In Navigation Menu Update Kanvas Icon In Navigation Menu Oct 27, 2024
@l5io
Copy link
Contributor

l5io commented Oct 27, 2024

🚀 Preview for commit 419f55b at: https://671e890b9cfbdf85dca195b4--layer5.netlify.app

@vishalvivekm
Copy link
Member

@Tharanishwaran
Thank you for your contribution!
Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).

Please add it as an agenda item to the meeting minutes.

@l5io
Copy link
Contributor

l5io commented Oct 30, 2024

🚀 Preview for commit e9c919a at: https://672224f0a4908f91aadb836a--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Oct 31, 2024

🚀 Preview for commit 2f9d805 at: https://6723cd58b03bd00dee4596ac--layer5.netlify.app

@@ -9,115 +9,35 @@ function KanvasIcon() {
viewBox="0 0 218.18 350.43"
>
<g id="Layer_2" data-name="Layer 2">
<g id="Layer_1-2" data-name="Layer 1">
<g id="Layer_1-2" data-name="Layer 1" transform="scale(0.7) translate(-100, 30)">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, thank you for changing this.
But I think if u need to reduce the size of svg, mb it will be better not to touch the transform for performance reasons, and play with viewBox property?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but @leecalcote requested we keep the original viewBox ('0 0 218.18 350.43'), which is why I used transform instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Replace MeshMap icons to new Kanvas logo
5 participants