-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Kanvas Icon In Navigation Menu #6037
base: master
Are you sure you want to change the base?
Update Kanvas Icon In Navigation Menu #6037
Conversation
Signed-off-by: Tharanishwaran <[email protected]>
🚀 Preview for commit 419f55b at: https://671e890b9cfbdf85dca195b4--layer5.netlify.app |
@Tharanishwaran Please add it as an agenda item to the meeting minutes. |
🚀 Preview for commit e9c919a at: https://672224f0a4908f91aadb836a--layer5.netlify.app |
Signed-off-by: Tharanishwaran <[email protected]>
🚀 Preview for commit 2f9d805 at: https://6723cd58b03bd00dee4596ac--layer5.netlify.app |
@@ -9,115 +9,35 @@ function KanvasIcon() { | |||
viewBox="0 0 218.18 350.43" | |||
> | |||
<g id="Layer_2" data-name="Layer 2"> | |||
<g id="Layer_1-2" data-name="Layer 1"> | |||
<g id="Layer_1-2" data-name="Layer 1" transform="scale(0.7) translate(-100, 30)"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, thank you for changing this.
But I think if u need to reduce the size of svg, mb it will be better not to touch the transform for performance reasons, and play with viewBox property?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but @leecalcote requested we keep the original viewBox ('0 0 218.18 350.43'), which is why I used transform instead.
Description
Replace Old MeshMap Icon with New Kanvas Logo in Navigation Menu
This PR fixes #6032
Notes for Reviewers
Screenshots
Signed commits