Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rails7 on travis ci #53

Closed
wants to merge 5 commits into from
Closed

Conversation

tknzk
Copy link
Contributor

@tknzk tknzk commented Feb 25, 2022

Why?

Support Rails7
add CI for Rails7
#52

What?

modified Appraisals for rails 7
add gemfiles/rails_7.gemfile
modified travis.yml ( add rails7)
modified spec/dummy/config/initializers/assets.rb
fixed error below on rails7

>> BUNDLE_GEMFILE=/Users/xxxx/src/github.com/tknzk/scim_rails/gemfiles/rails_7.gemfile bundle exec rspec spec/

An error occurred while loading ./spec/controllers/scim_rails/scim_users_controller_spec.rb.
Failure/Error: Rails.application.config.assets.version = '1.0'

NoMethodError:
  undefined method `assets' for #<Rails::Application::Configuration:0x0000000152623a88>
  Did you mean?  asset_host
# ./spec/dummy/config/initializers/assets.rb:4:in `<top (required)>'
# ./spec/dummy/config/environment.rb:5:in `<top (required)>'
# ./spec/spec_helper.rb:3:in `require'
# ./spec/spec_helper.rb:3:in `<top (required)>'
# ./spec/controllers/scim_rails/scim_users_controller_spec.rb:1:in `require'
# ./spec/controllers/scim_rails/scim_users_controller_spec.rb:1:in `<top (required)>'

Caveats

N/A

Testing Notes

N/A

Alternatives Considered

N/A

Further Reading

N/A

Merge Instructions

Please DO NOT squash my commits when merging

@thedayisntgray
Copy link

Any blockers getting this in any time soon?

@@ -17,7 +17,7 @@ Gem::Specification.new do |s|
s.files = Dir["{app,config,db,lib}/**/*", "MIT-LICENSE", "Rakefile", "README.md"]

s.required_ruby_version = "~> 2.4"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably use a newer version of ruby that is not at end of life.
https://endoflife.date/ruby

ivanyv added a commit to ivanyv/scim_rails that referenced this pull request Feb 21, 2023
ivanyv added a commit to ivanyv/scim_rails that referenced this pull request Feb 21, 2023
@tknzk tknzk changed the title Support rails7 Support rails7 on travis ci Jul 12, 2024
@tknzk tknzk closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants