-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support rails7 on travis ci #53
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any blockers getting this in any time soon? |
scim_rails.gemspec
Outdated
@@ -17,7 +17,7 @@ Gem::Specification.new do |s| | |||
s.files = Dir["{app,config,db,lib}/**/*", "MIT-LICENSE", "Rakefile", "README.md"] | |||
|
|||
s.required_ruby_version = "~> 2.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably use a newer version of ruby that is not at end of life.
https://endoflife.date/ruby
ivanyv
added a commit
to ivanyv/scim_rails
that referenced
this pull request
Feb 21, 2023
ivanyv
added a commit
to ivanyv/scim_rails
that referenced
this pull request
Feb 21, 2023
gja
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Support Rails7
add CI for Rails7
#52
What?
modified Appraisals for rails 7
add gemfiles/rails_7.gemfile
modified travis.yml ( add rails7)
modified spec/dummy/config/initializers/assets.rb
fixed error below on rails7
Caveats
N/A
Testing Notes
N/A
Alternatives Considered
N/A
Further Reading
N/A
Merge Instructions
Please DO NOT squash my commits when merging