-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Opus support to CMake builds #386
Conversation
Are there pull requests for opus and opusfile? |
I've opened libsdl-org/opus#1 and libsdl-org/opusfile#1 with the required changes. |
These are in! |
I rebased your pr on top of current master to get CI to test with the updated submodules. |
After merging this, CI cmake runs are always failing: did we miss something? |
@madebr, do you know what's going on here? |
The error is in the vendored opusfile:
Due to my workstation currently out of order, I'm unable to push/test a fix. |
Or, we can just put a |
Hm, tried adding the package_version files, still fails |
Cmake package_version thing is fixed by this: But build fails for other reasons now - @slouken, for you:
|
Well the cmake script was missing mp3utils.c - adding all missing sources fixed it. |
I opened a ticked at xiph opusfile: xiph/opusfile#33 |
This should not be merged until the necessary CMake changes are backported to the SDL branches for opus and opusfile.