fix: Support new json type url #2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
java-sdk
java-sdk-protobuf
kalix-runtime
efgpinto
approved these changes
Nov 8, 2024
| @@ -10,7 +10,7 @@ object Dependencies { | |||
| val RuntimeVersion = System.getProperty( | |||
| "kalix-runtime.version", | |||
| // temporarily accept the old system property name | |||
| System.getProperty("kalix-proxy.version", "1.1.46")) | |||
| System.getProperty("kalix-proxy.version", "1.2.0")) | |||
There was a problem hiding this comment.
If we are bumping here, should we also bump the remaining places? Or maybe we do on a separate PR?
There was a problem hiding this comment.
Ah, I didn't notice that from Ciscos original PR, hmm. Might be fine to do here, to make sure tests are run against the new version. We anyway want that bump.
github-actions
bot
added
the
Documentation
|
I jsut remembered we have some hardcoded ones here |
|
I think that's fine in that direction, the important part here is to accept the json.akka.io typeurl when it shows up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #2239
For compatibility with runtime 1.2.0
Also bumps runtime to 1.2.0