feat: Add variable that handles semantic check for sudoers #22
Conversation
|
[citest] |
| @@ -0,0 +1,579 @@ | |||
| #!/usr/bin/python | |||
There was a problem hiding this comment.
We will need some python unit tests for this module. Maybe the source has some tests.
There was a problem hiding this comment.
I am adding python unit tests to CI in #23
|
I believe scan_sudoers script will be rewritten in future so it uses cvtsudoers json output. This was just easier for now. |
radosroka
force-pushed
the
idempotency
branch
2 times, most recently
from
0a11d5c
to
7a00c2e
Compare
|
[citest] |
spetrosi
changed the title
|
Please rebase to get Python CI tests |
radosroka
force-pushed
the
idempotency
branch
from
3bbff69
to
f022435
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
[citest] |
radosroka
force-pushed
the
idempotency
branch
6 times, most recently
from
2574a06
to
79cc171
Compare
radosroka
force-pushed
the
idempotency
branch
from
79cc171
to
f70861e
Compare
|
[citest] |
radosroka
force-pushed
the
idempotency
branch
2 times, most recently
from
e865fe4
to
c093c9c
Compare
radosroka
force-pushed
the
idempotency
branch
from
c093c9c
to
829473f
Compare
radosroka
force-pushed
the
idempotency
branch
from
829473f
to
ad3a5c0
Compare
|
[citest] |
This variable provides semantic check of already configured sudoers in case ansible setup is not needed and it is skipped. Signed-off-by: Radovan Sroka <[email protected]>
radosroka
force-pushed
the
idempotency
branch
from
ad3a5c0
to
5290383
Compare
|
[citest] |
radosroka
force-pushed
the
idempotency
branch
from
5290383
to
7c69150
Compare
|
[citest] |
|
the tests cannot find the module you can also remove the |
|
@radosroka I submitted a PR against your branch - radosroka#2 - this should make the linters and tests all pass |
|
[citest] |
1 similar comment
|
[citest] |
|
[citest] |
sudoers will be scanned every time since it's easier to have the strucure generated every time
Co-authored-by: Richard Megginson <[email protected]>
radosroka
force-pushed
the
idempotency
branch
from
d423b97
to
9e5cb8c
Compare
|
[citest] |
I don't either. I suppose a user could specify some value that would cause problems, but the likelihood of that is extremely low, and it won't cause big problems even if so. plus:
which will completely eliminate the regex problem in the future. |
Enhancement: Add variable that handles semantic check for sudoers.
Reason: This was part of the original MVP of the role.
Result: To make role really idempotent.
Issue Tracker Tickets (Jira or BZ if any):
https://issues.redhat.com/browse/SECENGSP-5532