[RTG] Add some additional debug printing #7889
Open
+104
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maerhart
force-pushed
the
maerhart-rtg-elaboration-debug-printing
branch
from
9657c9d
to
5830157
Compare
seldridge
reviewed
Nov 25, 2024
Comment on lines
+77
to
+84
| virtual std::string toString() const { | ||
| std::string out; | ||
| llvm::raw_string_ostream stream(out); | ||
| stream << "<opaque "; | ||
| value.print(stream); | ||
| stream << " at " << this << ">"; | ||
| return out; | ||
| } |
There was a problem hiding this comment.
Can this be done by defining the << operator. This can also, if only used in debug, can be guarded under NDEBUG. E.g., something like https://github.com/llvm/circt/blob/main/include/circt/Analysis/FIRRTLInstanceInfo.h#L198
There was a problem hiding this comment.
That's a great point! Thanks for reviewing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, preserve the set order when computing set differences.